Skip to content

feat: support MF share treeshake #12250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
2heal1 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: support MF share treeshake #12250

2heal1 wants to merge 2 commits into from

Conversation

@2heal1
Copy link
Member

@2heal1 2heal1 commented Nov 20, 2025

Summary

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Nov 20, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit e27a87e
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6937eaced9e6c000088f931f

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Nov 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025 •
edited
Loading

📦 Binary Size-limit

Comparing e27a87e to fix: add test/include/exclude options to EvalSourceMapDevToolPlugin (#12392) by harpsealjs

❌ Size increased by 236.88KB from 47.71MB to 47.94MB (⬆️0.48%)

@2heal1 2heal1 force-pushed the feat/shared-treeshake branch from a55f482 to 4bccd0f Compare November 20, 2025 07:44
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 20, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12250 will not alter performance

Comparing feat/shared-treeshake (e27a87e) with main (f375692)

Summary

✅ 17 untouched

@2heal1 2heal1 force-pushed the feat/shared-treeshake branch from 43683b8 to b49c5b5 Compare November 21, 2025 08:59
@2heal1 2heal1 force-pushed the feat/shared-treeshake branch from 635668b to 98a6db7 Compare November 24, 2025 03:32
@2heal1 2heal1 force-pushed the feat/shared-treeshake branch from 09e0e3f to 611139b Compare November 25, 2025 09:48
@2heal1 2heal1 force-pushed the feat/shared-treeshake branch from a052b96 to 2219929 Compare December 9, 2025 08:14
@2heal1 2heal1 force-pushed the feat/shared-treeshake branch from 2219929 to 3c0a94e Compare December 9, 2025 08:28
@2heal1
fix(module-federation): correct shared module name and optimize tree …
e27a87e 
…shaking

fix incorrect module name in shared config and test cases
change async process_module to sync using block_on for better performance
update shared exports optimization to handle side effects properly
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Rsdoctor Bundle Diff Analysis

Found 5 project(s) in monorepo.

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: f375692ed8 | PR: #12392

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB 0 B (0.0%)
📄 JavaScript 5.7 MB 5.7 MB 0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: f375692ed8 | PR: #12392

Metric Current Baseline Change
📊 Total Size 823.6 KB 823.6 KB 0 B (0.0%)
📄 JavaScript 823.6 KB 823.6 KB 0 B (0.0%)
🎨 CSS 0 B 0 B N/A
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: f375692ed8 | PR: #12392

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB 0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB 0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: f375692ed8 | PR: #12392

Metric Current Baseline Change
📊 Total Size 984.3 KB 984.3 KB 0 B (0.0%)
📄 JavaScript 984.3 KB 984.3 KB 0 B (0.0%)
🎨 CSS 0 B 0 B N/A
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: rome Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: f375692ed8 | PR: #12392

Metric Current Baseline Change
📊 Total Size 2.1 MB 2.1 MB 0 B (0.0%)
📄 JavaScript 2.0 MB 2.0 MB 0 B (0.0%)
🎨 CSS 83.0 KB 83.0 KB 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hardfist hardfist Awaiting requested review from hardfist hardfist will be requested when the pull request is marked ready for review hardfist is a code owner

@ahabhgk ahabhgk Awaiting requested review from ahabhgk ahabhgk will be requested when the pull request is marked ready for review ahabhgk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@2heal1